SolidWallOfCode commented on issue #7052: URL: https://github.com/apache/trafficserver/issues/7052#issuecomment-666758855
I didn't realize this wasn't well commented. After an online discussion, it was decided the root of the problem was the self loop detection was done too early. In particular, it did not make sense to anyone that it was done immediately after the DNS lookup, which can happen before cache read. A bad side effect of this is that it can not only interfere with parent selection, but it fails to detect loops in parent selection precisely because it is done too early. The change to be made is to move the direct loop detection to `HttpSM::do_http_server_open` which is where the upstream connection is opened. There is already a slew of checks in that method which are done just before connecting, such as checking for an existing session, checking for too many connections, checking remap ACLs, etc. It seems natural that direct self loop detection should also be done in there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
