maskit commented on issue #5230:
URL: https://github.com/apache/trafficserver/issues/5230#issuecomment-728578357


   The limitation for intermediary is also on QPACK spec.
   https://quicwg.org/base-drafts/draft-ietf-quic-qpack.html#section-4.5.4
   https://quicwg.org/base-drafts/draft-ietf-quic-qpack.html#section-7.4
   
   I think keeping the representation info is not so difficult if we use 
HttpHdr. I'd add "sensitive" flag to MIMEField. I proposed it once at the very 
beginning of HTTP/2 implementation, but it was omitted because it was 
considered as not worth increasing the size of MIMEField.
   
   Because of that, we currently don't have a way to protect header fields on 
HTTP layer, and we do special handling inside HPACK for two specific headers.
   
https://github.com/apache/trafficserver/blob/b71249cb1a06e44ebc5e288bcca915afbacc2a6a/proxy/http2/HPACK.cc#L958-L960
   This code could be generalized if we added the flag. And then just setting 
the flag on decoding should retain the representation.
   
   
   For the interface between ProxyTransaction and HttpSM, I have no idea. I 
understand we have to deal with transform plugins, but I'm not so sure about 
extending VIO. It's already hard to use correctly. I saw many bugs that were 
related to nbytes and ndone.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to