jrushford commented on issue #7375: URL: https://github.com/apache/trafficserver/issues/7375#issuecomment-741056671
@c-taylor I submitted PR #7377 that I think will help. It removes a couple of redundant calls to getHostStatus() in ParentConsistentHash::selectParent(). Also, when getHostStatus() is called, it checks to see if the internal unordered_map that it uses is empty or not. If empty, ie no parents marked down with traffic_ctl` there is no need to lock and search the map so, it returns right away with the default HOST_STATUS_UP. I'm sure you'll see improvement when there are no hosts marked down with 'traffic_ctl host down' but, when you mark at least one down with 'traffic_ctl' the map will then be locked and searched. I think in this case the removal of the two redundant calls will be helpful. I'd appreciate it if you could retest with this patch and let me know wether it's helped. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
