bneradt commented on issue #7380:
URL: https://github.com/apache/trafficserver/issues/7380#issuecomment-749314050


   Good observations.
   
   > When the `number_of_redirections` is more than 1 and the negative cache is 
enabled, the transaction comes into line 4469 twice. The `HTTPCacheAlt`, which 
allocated on the first call, leaks because it's not freed before the second 
call of `HTTPInfo::create()`.
   > 
   > 
https://github.com/apache/trafficserver/blob/95d1069a9c5f70fe8b0fb57feec95e559ab92b91/proxy/http/HttpTransact.cc#L4467-L4469
   
   I need to spend some time thinking through how the negative caching fix 
introduced this. It's not obvious to me from the patch. Is it your observation 
that the negative caching fix reveals this because now, rather than being 
served incorrectly from the cache, the redirect is followed?
   
   > 
   > Moreover, the master & 9.0.x has the same issue.
   > 
   
   To be complete: that change also went into 7.x as well via: 
https://github.com/apache/trafficserver/pull/7357
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to