bneradt commented on issue #6909: URL: https://github.com/apache/trafficserver/issues/6909#issuecomment-867917870
I've investigated this a bit in the past. To restate the context: when someone submits a PR for review, the desire is for CI to rebase or merge the commits in the PR on top of the latest associated branch before the CI runs. Our Jenkins CI does not implement this by hand. Rather, this mechanism is done via a Jenkins plugin. As many of us have experienced, this plugin seems to have a problem when the commits in the PR change. When these commits change, Jenkins appropriately re-runs the CI, but the plugin seems to have an off-by-one issue in which it runs the CI against the previous commit instead of the latest one. I've experienced this, as @maskit mentioned in the initial commit, with force pushes on the PR's branch. I'm not sure whether it is limited to force pushes. For instance, if I push a second commit on the branch for the PR, does this off-by-one issue happen? I'm not sure since I personally generally force push, keeping the number of my commits to one for a PR, rather than adding commits on top of the initial PR. I expect that our new CI environment will resolve this. It implements merging onto the latest branch differently. I've explicitly tested this by force pushing commits in our test github environment and observed that it did in fact run with the new commit content, so that's promising. I'll leave this bug open for now until we transition to the new CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
