ywkaras commented on issue #1921:
URL: https://github.com/apache/trafficserver/issues/1921#issuecomment-1812680131
@ShaiviAgarwal2 I suggest you don' t assume the custom scoped classes are
useless. You can first evaluate whether there is any advantage to having/using
them.
I did this quick search in the code:
```
wkaras ~/REPOS/TS
O$ grep -i -e 'class.*scope' -e 'struct.*scope' $(findsrc)
./include/tscore/ink_mutex.h:class ink_scoped_mutex_lock
./include/tscore/ink_memory.h: An instance of this class is used to hold
a contingent resource. When this object goes out of scope
./include/tscore/ink_memory.h:class ats_scoped_resource
./include/tscore/ink_memory.h:struct SCOPED_FD_TRAITS {
./include/tscore/ink_memory.h:class ats_scoped_fd : public
ats_scoped_resource<detail::SCOPED_FD_TRAITS>
./include/tscore/ink_memory.h:struct SCOPED_MALLOC_TRAITS {
./include/tscore/ink_memory.h:struct SCOPED_OBJECT_TRAITS {
./include/tscore/ink_memory.h:class ats_scoped_str : public
ats_scoped_resource<detail::SCOPED_MALLOC_TRAITS<char>>
./include/tscore/ink_memory.h:class ats_scoped_mem : public
ats_scoped_resource<detail::SCOPED_MALLOC_TRAITS<T>>
./include/api/InkAPIInternal.h: struct Scope {
./include/iocore/eventsystem/ConfigProcessor.h: template <typename
ClassType, typename ConfigType> struct scoped_config {
./include/proxy/hdrs/HdrHeap.h: while the instance of this class
exists. When it goes out of scope
./lib/yamlcpp/src/emitterstate.h:struct FmtScope {
./lib/swoc/include/swoc/MemSpan.h: * invalid in class scope and this needs
to be specialized for @c void.
./lib/catch2/catch.hpp: class ScopedMessage {
./lib/catch2/catch.hpp: class ScopedElement {
./plugins/experimental/access_control/config.h: Classifier _uriPathScope;
/**< @brief denylist (exclude) and allow-list (include) which path should have
the access control */
./plugins/experimental/stream_editor/stream_editor.cc:class scope_t
./plugins/experimental/stream_editor/stream_editor.cc:class rxscope : public
scope_t
./plugins/experimental/stream_editor/stream_editor.cc:class strscope :
public scope_t
./src/records/RecYAMLDecoder.cc:struct scoped_cond_lock {
./src/iocore/cache/P_CacheHosting.h: class ScopedReader
./src/iocore/cache/P_CacheHosting.h: class ScopedWriter
./src/iocore/cache/P_CacheHosting.h: friend class
ReplaceablePtr::ScopedReader;
./src/mgmt/rpc/server/unit_tests/test_rpcserver.cc:struct ScopedLocalSocket
: shared::rpc::IPCSocketClient {
./src/proxy/logging/Log.cc: class scope and static members provide a
protected namespace for all of
wkaras ~/REPOS/TS
O$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
