freak82 opened a new issue, #11376: URL: https://github.com/apache/trafficserver/issues/11376
Hi there, There is [this function](https://github.com/apache/trafficserver/blob/d31a40fecb19f80ae8b7ddbb2ff0efecc57bf7f9/plugins/header_rewrite/matcher.h#L189) and it has the following signature: ``` bool test_reg(const std::string &t, bool nocase = false) const ``` However, it seems to me that the `nocase` parameter is forgotten and should be removed. Here are my thoughts/reasons for this: 1. The `Matcher` class already takes `nocase` flag upon construction and stores it in a member variable. This same member variable is used in this function and in other functions of the class 2. This `test_reg` function is private and it's part of overload set of `test_reg` functions which are called by the public `test` function of the `Matcher`. There `nocase` argument is not passed. 3. The `nocase` argument is not used inside this `test_reg` function. It uses the `_nocase` member for debug printing, though. So, should the `nocase` argument of this function be removed? Or should it be used in this function instead of `_nocase` member? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficserver.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
