bneradt commented on PR #5: URL: https://github.com/apache/trafficserver-libswoc/pull/5#issuecomment-2581370779
> > `master` seems to be failing too. not sure if we should have a look. > > I don't think we have to worry too much about it. It fails the CMake build. I'm able to build it locally using scons just fine, and the lib/swoc in ATS works fine. > > Not that it would be bad to fix it, of course. But I don't think we need to spend cycles on it either. Digging into this briefly, I suppose `scons` simply isn't set up in this repo to build the unit tests. I can reproduce the issue locally easily enough with cmake when it builds the test_Lexicon test. The failure relates to this declaration: https://github.com/apache/trafficserver-libswoc/blob/dbb8e73e565e6bb775ad04d60d8fe1b67a1c4479/unit_tests/test_Lexicon.cc#L36-L44 Note the comment - we assume the declaration shouldn't be ambiguous. But the failure is: ``` FAILED: unit_tests/CMakeFiles/test_libswoc.dir/test_Lexicon.cc.o /usr/lib64/ccache/c++ -I/home/bneradt/src/trafficserver-libswoc/code/include -std=gnu++17 -Wall -Wextra -Werror -Wno-unused-parameter -Wno-format-truncation -Wno-invalid-offsetof -Wno-unused-variable -MD -MT unit_tests/CMakeFiles/test_libswoc.dir/test_Lexicon.cc.o -MF unit_tests/CMakeFiles/test_libswoc.dir/test_Lexicon.cc.o.d -o unit_tests/CMakeFiles/test_libswoc.dir/test_Lexicon.cc.o -c /home/bneradt/src/trafficserver-libswoc/unit_tests/test_Lexicon.cc /home/bneradt/src/trafficserver-libswoc/unit_tests/test_Lexicon.cc:44:1: error: call of overloaded ‘Lexicon(<brace-enclosed initializer list>)’ is ambiguous 44 | }; | ^ In file included from /home/bneradt/src/trafficserver-libswoc/unit_tests/test_Lexicon.cc:10: ``` Specifically: `error: call of overloaded ‘Lexicon(<brace-enclosed initializer list>)’ is ambiguous` The issue seems build related rather than functional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
