bneradt commented on code in PR #6:
URL:
https://github.com/apache/trafficserver-libswoc/pull/6#discussion_r1966051669
##########
code/include/swoc/DiscreteRange.h:
##########
@@ -836,7 +841,7 @@ template <typename METRIC, typename PAYLOAD> class
DiscreteSpace {
*
* Values in @a range are set to @a payload regardless of the current state.
*/
- self_type &mark(range_type const &range, PAYLOAD const &payload);
+ self_type &mark(range_type const &range, PAYLOAD const &payload, bool
updateTree = true);
Review Comment:
Think this should be `update_tree` instead? That would fit `range_type`.
##########
code/include/swoc/DiscreteRange.h:
##########
@@ -828,6 +829,10 @@ template <typename METRIC, typename PAYLOAD> class
DiscreteSpace {
~DiscreteSpace();
+ void mark_bulk(std::vector<std::pair<range_type, PAYLOAD>> const &marks);
+
+ void mark_bulk(std::pair<range_type, PAYLOAD>* start, size_t n);
Review Comment:
doxygen comments woud be helpful (comment also applies to other new
parameters, like updateTree).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
