JosiahWI commented on code in PR #10: URL: https://github.com/apache/trafficserver-libswoc/pull/10#discussion_r3677571848
########## .gitignore: ########## @@ -1,55 +1,76 @@ -# Compiled Object files +# Compiled Objects *.o *.obj -*.swp -*.cbp -# Pkg-config files -*.pc - -# Compiled Dynamic libraries +# Shared Libraries *.so *.dylib *.dll -# Compiled Static libraries +# Static Libraries *.a *.lib # Executables *.exe *.out *.app + +# Example Executables example/ex_diskstats example/ex_flat_space example/ex_host_file example/ex_lru_cache example/ex_netcompact example/ex_netdb + +# Test Executable unit_tests/test_libswoc -# CMake cruft +# Build Directories +build/ +Build/ +build-*/ +_build +_install +_sdk +_unit_tests + +# CMake Build Files *.cmake Review Comment: Does *.cmake need to be gitignored? CMake scripts are usually source code for builds and should be committed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
