phongn commented on issue #13129: URL: https://github.com/apache/trafficserver/issues/13129#issuecomment-5335518945
Do we need a cryptographically secure hash for the cache? If so, we should switch, even if MD5 is slow on older platforms. SHA-256 is perfectly fine for that, and SHA-512/256 even better on any 64-bit system (note, this is not SHA-512 or SHA-256). That said, it looks like `CryptoHash` prefers 64-bit hash keys? We might be able to use something like SipHash given we don't use the full size of even MD5. If we don't need a cryptographically secure hash, we might as well do what was suggested by @masaori335 : switch to something like xxHash or rapidhash or umash (see https://github.com/rurban/smhasher for some basic tests). cc: @bneradt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
