bryancall commented on issue #13660: URL: https://github.com/apache/trafficserver/issues/13660#issuecomment-5609882409
The open question in this issue is answered, and the answer is that the CI failure was never related to this change. I said I would chase why `AuTest 1of4` went red on a revision of #13652 that made this same change, before opening a pull request. I reproduced it locally on a `dev-asan` build and then baselined it. Five runs of the `regex_remap` AuTest for each revision, same machine, same build settings: | revision | pass | fail | |---|---|---| | unmodified master 7ed34a3d3c | 1 | 4 | | the reverted revision dccd8f0658 | 1 | 4 | | the fix in #13661 | 3 | 2 | Every assertion in the test passes. What fails is the `traffic_server` exit code, because LeakSanitizer reports a 104 byte leak from `ConfigReloadTask::start_progress_checker()` at `src/mgmt/config/ConfigReloadTrace.cc:394`, reached through the config reload the test performs. That is unrelated to regex matching and it is on master right now. Filed as #13662. Five runs each is too small to claim the fix branch is better than master; the only claim is that the flake exists without the change. The fix is now open as #13661. It also keeps the #5762 crash guard rather than retiring it: the guard run moves to a subject large enough to still exhaust the 1 MB stack, since the first `-46` threshold for that rule moves from 1377 bytes to 43702 bytes once the shared stack applies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
