bryancall commented on issue #13682: URL: https://github.com/apache/trafficserver/issues/13682#issuecomment-5675263216
Pull requests for this work, split so each one asks a single reviewable question: | PR | Scope | CIDs | |---|---|---| | #13689 | Real defects in test code — use-after-free, unbounded lengths, error handling | 15 | | #13690 | Delete leaf `RegressionSM` instances when they complete | 3 | | #13688 | Uncaught-exception reports (the throwing `_ink_assert` override) | 20 | | #13687 | Bound guarded lengths in Catch2 test bodies (`REQUIRE` does not constrain for Coverity) | 18 | | #13686 | Trivial cleanups — copies, dead null checks | 10 | 66 of the 74 CIDs in this issue. The remaining eight are the triage recommendations listed above and need marking in the Coverity UI rather than a patch. Suggested review order is #13686 and #13687 first (mechanical), then #13688 (one rationale), then #13689 (the one that deserves real scrutiny). #13690 is independent and needs a `traffic_server -R` run, so it does not block the others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
