[ https://issues.apache.org/jira/browse/TRAFODION-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324148#comment-16324148 ]
ASF GitHub Bot commented on TRAFODION-2886: ------------------------------------------- Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1380#discussion_r161255440 --- Diff: core/sql/executor/cluster.cpp --- @@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc) rc); if ( !next_ || *rc ) { --- End diff -- I cann't understand. Why remove the || *rc, I think there are two type results: 1、 First, if there are no memory, next_ will get NULL value. 2、 Second, there are some wrong happened in Cluster::Cluster In the second case, next_ will get a value, but *rc will is not EXE_OK. If we remove the || *rc, this check will pass, but there was an error happened. My understanding is wrong? > fix the null pointer Critical error checked by TScanCode > -------------------------------------------------------- > > Key: TRAFODION-2886 > URL: https://issues.apache.org/jira/browse/TRAFODION-2886 > Project: Apache Trafodion > Issue Type: Bug > Reporter: xiaozhong.wang > Priority: Critical > Attachments: Critical_trafodion_tscancode_codecheck.xml > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)