[
https://issues.apache.org/jira/browse/TRAFODION-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339781#comment-16339781
]
ASF GitHub Bot commented on TRAFODION-2802:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1413#discussion_r163950816
--- Diff: install/traf_checkset_env.sh ---
@@ -244,11 +244,14 @@ if [ ! -d ${javapath} ]; then
exit 1
fi
+source $HOME/.bashrc
--- End diff --
Sourcing ~/.bashrc and looking into this file is not a very good solution,
IMHO. There are so many other ways we can set JAVA_HOME. For example:
/etc/bashrc, ~/.trafodion, $TRAF_HOME/.sqenvcom.sh.
I would suggest to just check whether JAVA_HOME is set, otherwise duplicate
the code in $TRAF_HOME/.sqenvcom.sh that sets JAVA_HOME. If JAVA_HOME is not
already set, then you can then add a line
export JAVA_HOME=...
To the file ~/.trafodion.
> Prepare the build environment with one command
> ----------------------------------------------
>
> Key: TRAFODION-2802
> URL: https://issues.apache.org/jira/browse/TRAFODION-2802
> Project: Apache Trafodion
> Issue Type: New Feature
> Components: Build Infrastructure
> Affects Versions: any
> Environment: Red Hat and CentOS first
> Reporter: xiaozhong.wang
> Priority: Major
> Fix For: any
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newbie cann't create build environment without a hitch.
> Although has a script traf_tools_setup.sh, there are a lot of process needed
> to prepare before that.
> Give a script that can create build environment by one command, it's very
> useful.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
