[
https://issues.apache.org/jira/browse/TRAFODION-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352854#comment-16352854
]
ASF GitHub Bot commented on TRAFODION-2816:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1310#discussion_r166094408
--- Diff: core/conn/unixodbc/odbc/odbcclient/unixcli/cli/ctosqlconv.cpp ---
@@ -3565,12 +4229,12 @@ unsigned long ODBC::ConvertCharToInt64(SQLPOINTER
srcDataPtr,
int tempLen;
char cTmpBuf[100];
bool truncation = false;
-
+ int nuberLen = 0;
--- End diff --
The variable nuberLen doesn't seem to be used anywhere below. (It doesn't
hurt anything though.)
> ODBC data convert function split
> --------------------------------
>
> Key: TRAFODION-2816
> URL: https://issues.apache.org/jira/browse/TRAFODION-2816
> Project: Apache Trafodion
> Issue Type: Bug
> Components: client-odbc-linux, client-odbc-windows
> Affects Versions: 2.3
> Reporter: Weiqing Xu
> Assignee: XuWeixin
> Priority: Major
>
> Now, the data convert function in ODBC is very long , and very hard to
> maintenance, we need to refactor it with some short function.
> 1. split one long function to little functions to make it more easy to
> maintain.
> 2. support convert very long CHAR/VARCHAR to others struct like timestamp.
> 3. Don't modify SQLDataType for SQL_NUMERIC any more. Use FSDataType to
> decide the real data format.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
