[ 
https://issues.apache.org/jira/browse/TRAFODION-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381208#comment-16381208
 ] 

ASF GitHub Bot commented on TRAFODION-2883:
-------------------------------------------

Github user narendragoyal commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1457#discussion_r171364487
  
    --- Diff: core/sqf/monitor/linux/zclient.cxx ---
    @@ -1524,6 +1763,108 @@ int CZClient::WatchNode( const char *nodeName )
         return(rc);
     }
     
    +int CZClient::WatchNodeMasterDelete( const char *nodeName )
    +{
    +    const char method_name[] = "CZClient::WatchMasterDelete";
    +    TRACE_ENTRY;
    +    
    +    int rc = -1;
    +    stringstream newpath;
    +    newpath.str( "" );
    +    newpath << zkRootNode_.c_str() 
    +            << zkRootNodeInstance_.c_str() 
    +            << ZCLIENT_MASTER_ZNODE
    +            << nodeName;
    +           
    +    string monZnode = newpath.str( );
    +    
    +    if (trace_settings & (TRACE_INIT | TRACE_RECOVERY))
    +    {
    +        trace_printf( "%s@%d zoo_delete(%s)\n"
    +                    , method_name, __LINE__
    +                    , monZnode.c_str() );
    +    }
    +   
    +    rc = zoo_delete( ZHandle
    +                   , monZnode.c_str( )
    +                   , -1 );
    +    if ( rc == ZOK )
    +    {
    +        if (trace_settings & (TRACE_INIT | TRACE_RECOVERY))
    +        {
    +            trace_printf( "%s@%d (MasterMonitor) WatchNodeMasterDelete 
deleted %s, with rc == ZOK\n"
    +                        , method_name, __LINE__
    +                        , nodeName );
    +        }
    +        char buf[MON_STRING_BUF_SIZE];
    +        snprintf( buf, sizeof(buf)
    +                , "[%s], znode (%s) deleted!\n"
    +                , method_name, nodeName );
    +        mon_log_write(MON_ZCLIENT_WATCHMASTERNODEDELETE_1, SQ_LOG_INFO, 
buf);
    +    }
    +    else if ( rc == ZNONODE )
    +    {
    +        // This is fine since we call it indiscriminately
    +        if (trace_settings & (TRACE_INIT | TRACE_RECOVERY))
    +        {
    +            trace_printf( "%s@%d (MasterMonitor) WatchNodeMasterDelete 
deleted %s, with rc == ZNONODE (fine)\n"
    +                        , method_name, __LINE__
    +                        , nodeName );
    +        }
    +    }
    +    else if ( rc == ZCONNECTIONLOSS || 
    +              rc == ZOPERATIONTIMEOUT )
    +    {
    +        if (trace_settings & (TRACE_INIT | TRACE_RECOVERY))
    +        {
    +            trace_printf( "%s@%d (MasterMonitor) WatchNodeMasterDelete 
deleted %s, with rc == ZOK\n"
    --- End diff --
    
    Perhaps need to be traced as an error with the actual rc ?


> Preliminary Trafodion Foundation Scalability Enhancements
> ---------------------------------------------------------
>
>                 Key: TRAFODION-2883
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2883
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: dtm, foundation, installer
>    Affects Versions: 2.3
>            Reporter: Gonzalo E Correa
>            Assignee: Gonzalo E Correa
>            Priority: Major
>             Fix For: 2.3
>
>
> Initial changes required to:
>   - AGENT mode monitor
>       o Preliminary change to remove dependency on OpenMPI during 
> initialization of operational cluster by creating a cluster
>           of one node (MASTER monitor) where other remote nodes (SLAVE 
> monitors) join the cluster through the MASTER
>  - MASTER monitor selection
>  - Scale bug fixes found when creating clusters greater than 120 nodes



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to