[ 
https://issues.apache.org/jira/browse/TRAFODION-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388989#comment-16388989
 ] 

ASF GitHub Bot commented on TRAFODION-2940:
-------------------------------------------

Github user kevinxu021 commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1427#discussion_r172733924
  
    --- Diff: dcs/src/main/java/org/trafodion/dcs/master/DcsMaster.java ---
    @@ -129,19 +170,19 @@ public void run() {
                 instance = "1";
             } catch (NullPointerException e) {
                 LOG.error("No args found: ", e);
    -            System.exit(1);
    +            return -1;
             } catch (ParseException e) {
                 LOG.error("Could not parse: ", e);
    -            System.exit(1);
    +            return -1;
             }
     
             try {
                 zkc = new ZkClient();
                 zkc.connect();
                 LOG.info("Connected to ZooKeeper");
             } catch (Exception e) {
    -            LOG.error(e);
    -            System.exit(1);
    +            LOG.error(e.getMessage(), e);
    +            return 1;
    --- End diff --
    
    Close zk connection while any connection exception happens. it's better to 
use specific Exception for zookeeper.


> In HA env, one node lose network, when recover, trafci can't use
> ----------------------------------------------------------------
>
>                 Key: TRAFODION-2940
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2940
>             Project: Apache Trafodion
>          Issue Type: Bug
>    Affects Versions: any
>            Reporter: mashengchen
>            Assignee: mashengchen
>            Priority: Major
>             Fix For: 2.3
>
>
> In HA env, if one node lose network for a long time , once network recover, 
> there will have two floating ip, two working dcs master, and trafci can't be 
> use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to