[ 
https://issues.apache.org/jira/browse/TRAFODION-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388988#comment-16388988
 ] 

ASF GitHub Bot commented on TRAFODION-2940:
-------------------------------------------

Github user kevinxu021 commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1427#discussion_r172735971
  
    --- Diff: dcs/src/main/java/org/trafodion/dcs/master/DcsMaster.java ---
    @@ -262,12 +308,38 @@ public void run() {
                 future.get();// block
     
             } catch (Exception e) {
    -            LOG.error(e);
    -            e.printStackTrace();
    +            LOG.error(e.getMessage(), e);
    +            try {
    +                FloatingIp floatingIp = FloatingIp.getInstance(this);
    +                floatingIp.unbindScript();
    +            } catch (Exception e1) {
    +                if (LOG.isErrorEnabled()) {
    +                    LOG.error("Error creating class FloatingIp [" + 
e.getMessage() + "]", e1);
    +                }
    +            }
                 if (pool != null)
                     pool.shutdown();
    -            System.exit(0);
    +            if (ls != null) {
    +                ListenerWorker lw = ls.getWorker();
    +                if (lw != null) {
    +                    lw.interrupt();
    +                    LOG.info("Interrupt listenerWorker.");
    +                }
    +                ls.interrupt();
    +                LOG.info("Interrupt listenerService.");
    +            }
    +            if (infoServer != null) {
    +                try {
    +                    infoServer.stop();
    +                    LOG.info("Stop infoServer.");
    +                } catch (Exception e1) {
    +                    LOG.error(e1.getMessage(), e1);
    +                }
    +            }
    +            return 1;
    +
    --- End diff --
    
    Add try-catch for each progress.


> In HA env, one node lose network, when recover, trafci can't use
> ----------------------------------------------------------------
>
>                 Key: TRAFODION-2940
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2940
>             Project: Apache Trafodion
>          Issue Type: Bug
>    Affects Versions: any
>            Reporter: mashengchen
>            Assignee: mashengchen
>            Priority: Major
>             Fix For: 2.3
>
>
> In HA env, if one node lose network for a long time , once network recover, 
> there will have two floating ip, two working dcs master, and trafci can't be 
> use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to