[ 
https://issues.apache.org/jira/browse/TRAFODION-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419246#comment-16419246
 ] 

ASF GitHub Bot commented on TRAFODION-3016:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1501#discussion_r178103261
  
    --- Diff: win-odbc64/odbcclient/drvr35/cstmt.cpp ---
    @@ -1063,7 +1063,20 @@ SQLRETURN CStmt::SendSQLCommand(BOOL SkipProcess, 
SQLCHAR *StatementText,
                 else
                     m_StmtType = TYPE_UNKNOWN;
             }
    -
    +        else if (strcmp(token, "SET") == 0)
    +        {
    +            token = strtok(NULL, delimiters);
    +            if (token != NULL && strcmp(token, "NAMES") == 0)
    +            {
    +                token = strtok(NULL, delimiters);
    +                if (token != NULL && strcmp(token, "'UTF8'") == 0)
    --- End diff --
    
    I'm wondering if there should be an "else" for this "if"? Suppose I say, 
"SET NAMES 'UTF9'", what happens?


> windows odbc driver add support UTF8 output
> -------------------------------------------
>
>                 Key: TRAFODION-3016
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-3016
>             Project: Apache Trafodion
>          Issue Type: Bug
>          Components: client-odbc-windows
>    Affects Versions: 2.3
>         Environment: Client Windows 7
> Server Centos 6.7
>            Reporter: XuWeixin
>            Assignee: XuWeixin
>            Priority: Major
>             Fix For: 2.3
>
>
> The Chinese encode of windows is GBK.
> So driver will convert the Chinese characters to GB2312.
> But when UTF-8 is needed, it is not supported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to