[
https://issues.apache.org/jira/browse/TRAFODION-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443375#comment-16443375
]
ASF GitHub Bot commented on TRAFODION-3009:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1522#discussion_r182604952
--- Diff: core/sql/executor/ExHdfsScan.cpp ---
@@ -626,14 +625,23 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
else
extraBytesRead_ = 0;
// headRoom_ is the number of extra bytes to be read
(rangeTailIOSize)
- // If EOF is reached while reading the range and the
extraBytes read
- // is less than headRoom_ then process all the data till EOF
- // TODO: If the whole range fits in one buffer, it is need
too to process rows till EOF for the last range alone
- // No easy way to identify that last range read, but can
identify that it is not the first range.
- // The rows could be read more than once if there are more
than 2 ranges.
- // Fix optimizer not to have more than 2 ranges in that case
- if (retArray_[IS_EOF] && extraBytesRead_ < headRoom_ &&
hdfo->getStartOffset() != 0)
- extraBytesRead_ = 0;
+ // If the whole range fits in one buffer, it is needed to
process rows till EOF for the last range alone.
+/*
--- End diff --
Is the commented-out code needed anymore? Should we get rid of it?
> Streamline error handling in Executor utility commands
> ------------------------------------------------------
>
> Key: TRAFODION-3009
> URL: https://issues.apache.org/jira/browse/TRAFODION-3009
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: -exe, sql-exe
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
> Priority: Major
>
> Executor utility commands are the commands that issue sql statements during
> its execution to complete its task. These operators are derived from
> ExExeUtilTcb operator in Trafodion. These commands assume ComDiagsArea is
> allocated in advance. This is not in accordance with the design as outlined in
> [https://cwiki.apache.org/confluence/display/TRAFODION/SQL+Diagnostics+Architecture+and+Design]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
