[ 
https://issues.apache.org/jira/browse/TRAFODION-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469642#comment-16469642
 ] 

ASF GitHub Bot commented on TRAFODION-3065:
-------------------------------------------

Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1557#discussion_r187199413
  
    --- Diff: core/sql/src/main/java/org/trafodion/sql/HDFSClient.java ---
    @@ -151,10 +180,38 @@ public Object call() throws IOException
                 bufOffset_ += bytesRead;
                 pos_ += bytesRead;
                 lenRemain_ -= bytesRead;
    -         } while (lenRemain_ > 0);
    +         } while (lenRemain_ > 0); 
              return new Integer(totalBytesRead);
           }
    -   }
    +    } 
    +
    +    int compressedFileRead(int readLenRemain) throws IOException 
    +    {
    +       int totalReadLen = 0;
    +       int readLen;
    +       int offset = 0;
    +       int retcode;
    +
    +         int lenRemain = ((readLenRemain > bufArray_.length) ? 
bufArray_.length : readLenRemain);
    --- End diff --
    
    Negative might return an exception in read operation, while 0 might be 
harmless. I think forcing read at least once would help us to set the isEOF_ 
flag


> Trafodion to support compressed Hive Text formatted tables
> ----------------------------------------------------------
>
>                 Key: TRAFODION-3065
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-3065
>             Project: Apache Trafodion
>          Issue Type: New Feature
>          Components: sql-cmp, sql-exe
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Selvaganesan Govindarajan
>            Priority: Major
>             Fix For: 2.3
>
>
> Currently,  Trafodion doesn't support Hive text formatted compressed files.  
> The compressed file support will be provided with the refactored Hdfs scan 
> implementation only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to