[
https://issues.apache.org/jira/browse/TRAFODION-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517236#comment-16517236
]
ASF GitHub Bot commented on TRAFODION-2901:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1581#discussion_r196474928
--- Diff: core/sql/optimizer/RelExpr.cpp ---
@@ -13341,6 +13341,36 @@ void GenericUpdate::pushdownCoveredExpr(const
ValueIdSet &outputExpr,
newExternalInputs,
predicatesOnParent,
&localExprs);
+
+ if (avoidHalloween() && child(0) &&
+ child(0)->getOperatorType() == REL_SCAN &&
+ child(0)->getGroupAttr())
+ {
+ ValueIdSet cur_output =
child(0)->getGroupAttr()->getCharacteristicOutputs();
--- End diff --
This works, but is is not very efficient to create a copy of a ValueIdSet
just to check whether it is empty. You could just check
```
if (child(0)->getGroupAttr()->getCharacteristicOutputs().isEmpty())
```
in the line below.
> using sequence to do upsert get wrong number of rows after several times
> ------------------------------------------------------------------------
>
> Key: TRAFODION-2901
> URL: https://issues.apache.org/jira/browse/TRAFODION-2901
> Project: Apache Trafodion
> Issue Type: Bug
> Reporter: liu ming
> Assignee: Gu Haiyan
> Priority: Major
>
> create table test_seq
> (id LARGEINT not null
> ) primary key(id)
> SALT USING 48 PARTITIONS
> ATTRIBUTES ALIGNED FORMAT
> HBASE_OPTIONS
> (
> DATA_BLOCK_ENCODING = 'FAST_DIFF',
> MEMSTORE_FLUSH_SIZE = '1073741824'
> );
> create sequence seq1;
> upsert into test_seq select seqnum(seq1, next) from dual;
> upsert into test_seq select seqnum(seq1, next) from test_seq;
> upsert into test_seq select seqnum(seq1, next) from test_seq;
> upsert into test_seq select seqnum(seq1, next) from test_seq;
> upsert into test_seq select seqnum(seq1, next) from test_seq;
> upsert into test_seq select seqnum(seq1, next) from test_seq;
> upsert into test_seq select seqnum(seq1, next) from test_seq;
> upsert into test_seq select seqnum(seq1, next) from test_seq;
> upsert into test_seq select seqnum(seq1, next) from test_seq;
> --- 130 row(s) inserted.
> Should be 128 rows
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
