[
https://issues.apache.org/jira/browse/TRAFODION-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534383#comment-16534383
]
ASF GitHub Bot commented on TRAFODION-3049:
-------------------------------------------
GitHub user Weixin-Xu opened a pull request:
https://github.com/apache/trafodion/pull/1631
[TRAFODION-3049] ODBC Numeric convert skip the calculation of max value
When column is Numeric in the range of 1 to 18, the calculation of max
value will skip
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Weixin-Xu/incubator-trafodion 3049
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1631.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1631
----
commit 838f120b99660a1de3a2539cf1262af3d135d6df
Author: Weixin-Xu <xwx@...>
Date: 2018-07-05T06:58:36Z
when column is Numeric in the range of 1 to 18, the calculation of max
value will skip
----
> Inaccurate conditions of judgment cause low efficiency
> ------------------------------------------------------
>
> Key: TRAFODION-3049
> URL: https://issues.apache.org/jira/browse/TRAFODION-3049
> Project: Apache Trafodion
> Issue Type: Bug
> Components: client-odbc-linux, client-odbc-windows
> Affects Versions: any
> Reporter: XuWeixin
> Assignee: XuWeixin
> Priority: Major
> Fix For: 2.3
>
>
> In ctosqlconv.cpp, the code below :
> if( !(((SQLDataType == SQLTYPECODE_NUMERIC) && (targetPrecision > 18)) ||
> ((SQLDataType == SQLTYPECODE_NUMERIC_UNSIGNED) && (targetPrecision > 9))))
>
> Only when the column is NUMERIC(19+,n), the code will skip.
> It is only used for numeirc but now the other data type such as char will do
> the same process.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
