[ https://issues.apache.org/jira/browse/TRAFODION-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546095#comment-16546095 ]
ASF GitHub Bot commented on TRAFODION-3145: ------------------------------------------- Github user traflm commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1646#discussion_r202908302 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp --- @@ -10991,7 +10997,20 @@ CmpSeabaseDDL::setupHbaseOptions(ElemDDLHbaseOptions * hbaseOptionsClause, hbaseOptionsStr += optionStr; } } + if (!flushSize.isNull() && !memstoreFlushSizeOptionSpecified) + { + hbaseOption = new(STMTHEAP) HbaseCreateOption("MEMSTORE_FLUSH_SIZE", + flushSize.data()); + hbaseCreateOptions.insert(hbaseOption); + if (ActiveSchemaDB()->getDefaults().userDefault + (HBASE_MEMSTORE_FLUSH_SIZE_OPTION) == TRUE) + { + numHbaseOptions += 1; + sprintf(optionStr, "MEMSTORE_FLUSH_SIZE='%s'|", flushSize.data()); --- End diff -- I agree, I can change this into a more robust coding style, using snprintf. > Make "hbase_options" as default setting and use cqd to change the default > setting > --------------------------------------------------------------------------------- > > Key: TRAFODION-3145 > URL: https://issues.apache.org/jira/browse/TRAFODION-3145 > Project: Apache Trafodion > Issue Type: Improvement > Reporter: liu ming > Assignee: liu ming > Priority: Major > > As we know, for performance thinking, we always need to add below syntax in > “create table” syntax. And I know in latest version, we have made “ATTRIBUTES > ALIGNED FORMAT” as default, do we have a plan that make > HBASE_OPTIONS(including ENCODING、COMPRESSION、MEMESTORE) as the default > setting when creating table? I think this will be easier for end users? > ATTRIBUTES ALIGNED FORMAT > HBASE_OPTIONS > ( > DATA_BLOCK_ENCODING = 'FAST_DIFF', > COMPRESSION = 'SNAPPY', > MEMSTORE_FLUSH_SIZE = '1073741824' > ) > ; -- This message was sent by Atlassian JIRA (v7.6.3#76005)