[
https://issues.apache.org/jira/browse/TRAFODION-3171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567788#comment-16567788
]
ASF GitHub Bot commented on TRAFODION-3171:
-------------------------------------------
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1674#discussion_r207442360
--- Diff: core/sql/executor/ExHdfsScan.cpp ---
@@ -571,6 +569,7 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
hdfsScan_ = HdfsScan::newInstance((NAHeap *)getHeap(),
hdfsScanBuf_, hdfsScanBufMaxSize_,
hdfsScanTdb().hdfsIoByteArraySizeInKB_,
&hdfsFileInfoListAsArray_, beginRangeNum_,
numRanges_, hdfsScanTdb().rangeTailIOSize_,
+ isSequenceFile(),
hdfsScanTdb().recordDelimiter_,
--- End diff --
If we did not pass in the recordDelimiter_ previously, do we know if
previous code worked correctly for text format, when the record delimiter was
something other than /n ? This PR does not seem change anything for text format
reads, so if there was issue previously, it might still exist.
> Refactor Sequence File Reading to use the new implementation
> ------------------------------------------------------------
>
> Key: TRAFODION-3171
> URL: https://issues.apache.org/jira/browse/TRAFODION-3171
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-exe
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
> Priority: Major
>
> SequenceFileReader is done via JNI/Java earlier. However, the HdfsScan was
> traversing the older states in ExHdfsScanTcb work method. This new
> implementation should use the current ByteBuffer infrastructure to enable
> obsoleting the older implemenation
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
