[
https://issues.apache.org/jira/browse/TRAFODION-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577440#comment-16577440
]
ASF GitHub Bot commented on TRAFODION-1881:
-------------------------------------------
GitHub user traflm opened a pull request:
https://github.com/apache/trafodion/pull/1690
[TRAFODION-1881] A better way to solve TRAFODION-1858
In my previous fix to TRAFODION-1858, I add a new method to check if a
column is a system column by comparing the column name with "_SALT_",
"_DIVISION_" etc, that is not a good way.
This is a new implementation, it use more robust way to tell if a column is
a system column.
To check the RI, the predicate only need to check the user specified
Primary Column.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/traflm/trafodion TRAFODION-1881
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1690
----
commit cad4418c141fe5ea73888dc4b0a91272197cc14d
Author: Liu Ming <ovis_poly@...>
Date: 2018-08-12T02:05:31Z
[TRAFODION-1881] A better way to solve TRAFODION-1858
----
> Follow up TRAFODION-1858 , need a better fix
> --------------------------------------------
>
> Key: TRAFODION-1881
> URL: https://issues.apache.org/jira/browse/TRAFODION-1881
> Project: Apache Trafodion
> Issue Type: Bug
> Reporter: liu ming
> Assignee: liu ming
> Priority: Major
>
> TRAFODION-1858 is now fixed using a temp method. A better and complete
> solution is required.
> But to solve it entirely, it requires a more throughout refactor of many
> related parts of code.
> It is a real customer blocking issue, so we fix it with the temp solution and
> using this JIRA to follow up.
> The solution in TRAFODION-1858 is to add a new method to check the string
> name of a given column to tell if it is SALT column, or DIVSION column. The
> checking method is hardcoding the naming conversion, which may change and
> break the function.
> However, to use NAColumn's built-in helper checking methods, it needs the SQL
> compiler to generate correct constraint info from begining and change all the
> intermediate objects along the path. It may also need to change the METATABLE
> which contains information about constraints.
> So we use this JIRA to track, and need a longer time to find a good solution
> to solve TRAFODION-1858.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
