[ 
https://issues.apache.org/jira/browse/TRAFODION-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692054#comment-16692054
 ] 

ASF GitHub Bot commented on TRAFODION-3235:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1747#discussion_r234715228
  
    --- Diff: core/conn/odb/src/odb.c ---
    @@ -6246,7 +6248,8 @@ static void Oload(int eid)
                  trt[16];           /* translit to array */         
             char op;                /* 1=substr, 2=dconv, 3=tconv, 4=tsconv, 
5=replace,
                                        6=toupper, 7=tolower, 8=firstup, 
9=csubstr, 10=translit,
    -                                   11=comp, 12=comp3, 13=zoned, 
14=emptyasconst, 15=emptyasempty */
    +                                   11=comp, 12=comp3, 13=zoned, 
14=emptyasconst, 15=emptyasempty,
    +                                   16=div */
    --- End diff --
    
    Should the comments also include 17=trim?


> add div and trim function for map feature,  improve bad file print function.
> ----------------------------------------------------------------------------
>
>                 Key: TRAFODION-3235
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-3235
>             Project: Apache Trafodion
>          Issue Type: New Feature
>          Components: db-utility-odb
>            Reporter: 苏锦佩
>            Assignee: 苏锦佩
>            Priority: Major
>
> In some customer scenarios, they want below feature:
>  # Div function in the map file, so the numeric data in the data file can be 
> divided with some value before loading to the database. for example, we have 
> a COL NUMERIC(6,2) column and the data '123456' in the data file, we can use 
> the mapping rule 'COL:<field>\DIV:100' to translate the data to '1234.56' 
> before loading to the database.
>  # Trim function in the map file,  so if some field containing leading and 
> trailing space in the data file can be trimmed before loading to the 
> database. for example, suppose we have a COL CHAR(20) and the data '   abc    
> ' in the data file, we can use the mapping rule 'COL:<field>:TRIM' to 
> translate the data to 'abc' before loading to the database.
>  # Now, the odb tool will print a record for each ODBC error message in the 
> bad file. But some bad row may report more than one error message, so the bad 
> file may contain duplicated records. So add a fix to ensure that one bad 
> record only printed once in bad file. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to