[
https://issues.apache.org/jira/browse/TRAFODION-3314?focusedWorklogId=271196&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-271196
]
ASF GitHub Bot logged work on TRAFODION-3314:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/19 20:47
Start Date: 02/Jul/19 20:47
Worklog Time Spent: 10m
Work Description: DaveBirdsall commented on pull request #1846:
[TRAFODION-3314] Avoid generating redundant DDL in OSIM for unique constraints
URL: https://github.com/apache/trafodion/pull/1846#discussion_r299677737
##########
File path: core/sql/optimizer/OptimizerSimulator.cpp
##########
@@ -541,31 +541,43 @@ void OptimizerSimulator::dumpDDLs(const QualifiedName &
qualifiedName)
<<"."<< qualifiedName.getSchemaName()
<< ";" << endl;
+ // skippingSystemGeneratedIndex is set to TRUE to avoid generating
redundant
+ // DDL for system-generated indexes
+ NABoolean skippingSystemGeneratedIndex = FALSE;
outQueue->position();//rewind
for (int i = 0; i < outQueue->numEntries(); i++) {
OutputInfo * vi = (OutputInfo*)outQueue->getNext();
char * ptr = vi->get(0);
- // skip heading newline, and add a comment line
- // for the DDL text upto the first trailing '\n'
- Int32 ix = 0;
- for(; ptr[ix]=='\n'; ix++);
- if( strstr(ptr, "CREATE TABLE") ||
- strstr(ptr, "CREATE INDEX") ||
- strstr(ptr, "CREATE UNIQUE INDEX") ||
- strstr(ptr, "ALTER TABLE") )
+ if (strcmp(ptr,"\n-- The following index is a system created index
--") == 0)
+ skippingSystemGeneratedIndex = TRUE;
+ if (!skippingSystemGeneratedIndex)
{
- (*createTable) << "--";
- char* x = ptr+ix;
- while ( (*x) && *x != '\n' ) {
- (*createTable) << *x;
- x++;
- }
- (*createTable) << endl;
+ // skip heading newline, and add a comment line
+ // for the DDL text upto the first trailing '\n'
+ Int32 ix = 0;
+ for(; ptr[ix]=='\n'; ix++);
+ if( strstr(ptr, "CREATE TABLE") ||
+ strstr(ptr, "CREATE INDEX") ||
+ strstr(ptr, "CREATE UNIQUE INDEX") ||
+ strstr(ptr, "ALTER TABLE") )
+
+ {
+ (*createTable) << "--";
+ char* x = ptr+ix;
+ while ( (*x) && *x != '\n' ) {
+ (*createTable) << *x;
+ x++;
+ }
+ (*createTable) << endl;
+ }
+
+ //output ddl
+ (*createTable) << ptr << endl;
}
- //output ddl
- (*createTable) << ptr << endl;
+ if (skippingSystemGeneratedIndex && (strcmp(ptr,";") == 0)) // at
end of DDL to be skipped?
+ skippingSystemGeneratedIndex = FALSE;
Review comment:
Note to reviewers: The code from lines 556 through 576 in the new file is
merely re-indented lines 548 through 568 from the old file, with an "if
(!skippingSystemGenerated) { ... }" around it. Unfortunately the comparison
tool doesn't render this difference nicely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 271196)
Time Spent: 20m (was: 10m)
> OSIM generates redundant DDL for unique constraints
> ---------------------------------------------------
>
> Key: TRAFODION-3314
> URL: https://issues.apache.org/jira/browse/TRAFODION-3314
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-cmp
> Affects Versions: 2.4
> Reporter: David Wayne Birdsall
> Assignee: David Wayne Birdsall
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Unique constraints are usually implemented by creation of a unique index
> under the covers. When doing an OSIM CAPTURE of a query on a table that has a
> unique constraint, OSIM generates both an ALTER TABLE ADD CONSTRAINT
> statement and a CREATE UNIQUE INDEX statement in the CREATE_TABLE_DDLS.txt
> file. When this is replayed in OSIM LOAD, we get an error when creating the
> unique index.
> To fix this, perhaps OSIM should generate the CREATE UNIQUE INDEX statement
> only in commented-out form.
> {{To reproduce, run the following script in sqlci:}}
> {{?section setup}}
> {{drop table if exists t1 cascade;}}
> {{create table t1 (a int not null, b int not null, c int not null, primary
> key (a));}}
> {{alter table t1 add constraint uniqueb unique(b);}}
> {{?section osimgen}}
> {{control osim capture location 'osimgen';}}
> {{prepare xx from select b,count(*) from t1 group by b;}}
> {{control osim capture stop;}}
> {{Then in a separate session, do:}}
> {{control osim load from 'osimgen';}}
> {{This will fail with the following output:}}
> {{>>control osim load from '.';}}
> {{[OSIM]loading tables and views ...}}
> {{[OSIM]DROP TABLE IF EXISTS TRAFODION.SCH.T1 CASCADE;}}
> {{[OSIM]Step 1 Create Schemas:}}
> {{[OSIM]CREATE SCHEMA IF NOT EXISTS TRAFODION.SCH}}
> {{[OSIM]Step 2 Create Tables:}}
> {{[OSIM]CREATE TABLE TRAFODION.SCH.T1}}
> {{[OSIM] The following index is a system created index --CREATE UNIQUE INDEX
> UNIQUEB ON TRAFODION.SCH.T1}}
> {{[OSIM]ALTER TABLE TRAFODION.SCH.T1 ADD CONSTRAINT TRAFODION.SCH.UNIQUEB
> UNIQUE}}
> {{*** ERROR[1043] Constraint TRAFODION.SCH.UNIQUEB already exists.}}
> {{*** ERROR[6009] The Optimizer Simulator (OSIM): Create Table Error: -1043}}
> {{*** ERROR[8822] The statement was not prepared.}}
> {{>>exit;}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
