[jira] [Commented] (TRAFODION-37) Get "ROLLBACK WORK" and "COMMIT WORK" transactions be prepared when T2 driver is establishing connection

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TRAFODION-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628579#comment-14628579
 ] 

ASF GitHub Bot commented on TRAFODION-37:
-----------------------------------------

Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/28#discussion_r34718734
  
    --- Diff: core/conn/jdbc_type2/native/CSrvrConnect.cpp ---
    @@ -268,10 +268,10 @@ void SRVR_CONNECT_HDL::addSrvrStmt(SRVR_STMT_HDL 
*pSrvrStmt,BOOL internalStmt)
             mapOfInternalSrvrStmt[pSrvrStmt->stmtName]= pSrvrStmt;  // +++ map 
error
         }
     
    -
         //End of Soln. No.: 10-100202-7923
     
         count++;
    +    //pSrvrStmt->myKey = count;
    --- End diff --
    
    Thanks for removing some unneeded comments. Is this particular one needed ? 
In general if it might be good to clean up the method being touched (remove sol 
numbers, commented out code if not needed or add more comments, remove any MFC 
related code etc)


> Get "ROLLBACK WORK" and "COMMIT WORK" transactions be prepared when T2 driver 
> is establishing connection
> --------------------------------------------------------------------------------------------------------
>
>                 Key: TRAFODION-37
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-37
>             Project: Apache Trafodion
>          Issue Type: Improvement
>            Reporter: RuoYu Zuo
>            Assignee: RuoYu Zuo
>              Labels: features
>
> To make T2 driver supports rowset operation to enhance the performance of 
> batch insert and update, two SQL transactions ("commit" to make a succeeded 
> execution and "rollback" for failure) are required to be prepared in advance, 
> which shall be triggered in executing phase of rowset operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)