[ 
https://issues.apache.org/jira/browse/TRAFODION-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724567#comment-14724567
 ] 

ASF GitHub Bot commented on TRAFODION-353:
------------------------------------------

Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/69#discussion_r38379061
  
    --- Diff: core/sql/sqlcomp/PrivMgrPrivileges.cpp ---
    @@ -4407,6 +4609,60 @@ static void getColRowsForGranteeGrantor(
     
     
     // 
*****************************************************************************
    +// * Function: hasAllDMLPrivs                                              
    *
    +// *                                                                       
    *
    +// *    This function determines if a privilege bitmap has all the DML     
    *
    +// * privileges for a specified object type.                               
    *
    +// *                                                                       
    *
    +// 
*****************************************************************************
    +// *                                                                       
    *
    +// *  Parameters:                                                          
    *
    +// *                                                                       
    *
    +// *  <objectType>                 ComObjectType                      In   
    *
    +// *    is the type of the object.                                         
    *
    +// *                                                                       
    *
    +// *  <privBitmap>                 PrivObjectBitmap                   In   
    *
    +// *    is the bitmap representing the privileges.                         
    *
    +// *                                                                       
    *
    +// 
*****************************************************************************
    +static bool hasAllDMLPrivs(
    +   ComObjectType objectType,
    +   PrivObjectBitmap privBitmap)
    +
    +{
    +
    +   switch (objectType)
    +   {
    +      case COM_BASE_TABLE_OBJECT:
    +      case COM_VIEW_OBJECT:
    +         if (privBitmap.test(DELETE_PRIV) && privBitmap.test(INSERT_PRIV) 
&&
    +             privBitmap.test(REFERENCES_PRIV) && 
privBitmap.test(SELECT_PRIV) &&
    +             privBitmap.test(UPDATE_PRIV))
    +            return true;
    +         break;
    +      case COM_LIBRARY_OBJECT:
    +         if (privBitmap.test(UPDATE_PRIV) && privBitmap.test(USAGE_PRIV))
    +            return true;
    +         break;      
    +      case COM_STORED_PROCEDURE_OBJECT:
    +      case COM_USER_DEFINED_ROUTINE_OBJECT:
    +         if (privBitmap.test(EXECUTE_PRIV))
    +            return true;
    +      case COM_SEQUENCE_GENERATOR_OBJECT:
    --- End diff --
    
    Is a break needed here ?


> LP Bug: 1327302 - traf_authentication_config template reference incorrect 
> script
> --------------------------------------------------------------------------------
>
>                 Key: TRAFODION-353
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-353
>             Project: Apache Trafodion
>          Issue Type: Bug
>          Components: sql-security
>            Reporter: Paul Low
>            Assignee: Cliff Gray
>            Priority: Minor
>
> Line 26 in the template file 
> $MY_SQROOT/sql/scripts/traf_authentication_config refers to a script 
> 'sqauthon'.  The script name needs to be updated to 
> 'traf_authentication_setup'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to