[
https://issues.apache.org/jira/browse/TRAFODION-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944235#comment-14944235
]
ASF GitHub Bot commented on TRAFODION-25:
-----------------------------------------
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/102#discussion_r41210222
--- Diff: core/sql/generator/GenPreCode.cpp ---
@@ -4368,14 +4368,6 @@ RelExpr * GenericUpdate::preCodeGen(Generator *
generator,
identityCol = valId.getNAColumn();
}
- if ((getOperatorType() != REL_HBASE_UPDATE) &&
- (mergeInsertRecExpr().entries() > 0))
- {
- *CmpCommon::diags() << DgSqlCode(-3241)
- << DgString0(" Non-unique ON clause not allowed
with INSERT.");
- GenExit();
- }
-
--- End diff --
I am glad that this check was removed. Can you please tell me if we ever
see any of the other 3241 errors being triggered from the generator? To me this
indicates that the binder "let one get through". I would like to eventually
raise all these 3241 errors in thebinder.
> Insert, delete and update operators should use specialized cost method
> -----------------------------------------------------------------------
>
> Key: TRAFODION-25
> URL: https://issues.apache.org/jira/browse/TRAFODION-25
> Project: Apache Trafodion
> Issue Type: Bug
> Reporter: Qifan Chen
> Assignee: David Wayne Birdsall
> Labels: performance
>
> In Trafodion, insert, delete and update operators do not use a specialized
> cost method that model the true operation involved.
> As a result, these operators can be assigned a zero cost and the query plan
> may not be optimal. In one example, a delete query against a partitioned
> table may get a serial plan.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
