[
https://issues.apache.org/jira/browse/TRAFODION-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945376#comment-14945376
]
ASF GitHub Bot commented on TRAFODION-25:
-----------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/102#discussion_r41293164
--- Diff: core/sql/generator/GenPreCode.cpp ---
@@ -4368,14 +4368,6 @@ RelExpr * GenericUpdate::preCodeGen(Generator *
generator,
identityCol = valId.getNAColumn();
}
- if ((getOperatorType() != REL_HBASE_UPDATE) &&
- (mergeInsertRecExpr().entries() > 0))
- {
- *CmpCommon::diags() << DgSqlCode(-3241)
- << DgString0(" Non-unique ON clause not allowed
with INSERT.");
- GenExit();
- }
-
--- End diff --
Yes, some of the 3241 errors remain in the generator. I had to move this
particular test up to the binder because with the costing changes I was
sometimes failing to get a plan in phase 1 of optimization.
> Insert, delete and update operators should use specialized cost method
> -----------------------------------------------------------------------
>
> Key: TRAFODION-25
> URL: https://issues.apache.org/jira/browse/TRAFODION-25
> Project: Apache Trafodion
> Issue Type: Bug
> Reporter: Qifan Chen
> Assignee: David Wayne Birdsall
> Labels: performance
>
> In Trafodion, insert, delete and update operators do not use a specialized
> cost method that model the true operation involved.
> As a result, these operators can be assigned a zero cost and the query plan
> may not be optimal. In one example, a delete query against a partitioned
> table may get a serial plan.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
