[ 
https://issues.apache.org/jira/browse/TRAFODION-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945472#comment-14945472
 ] 

ASF GitHub Bot commented on TRAFODION-25:
-----------------------------------------

Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/102#discussion_r41299310
  
    --- Diff: core/sql/sqlcomp/PrivMgrPrivileges.cpp ---
    @@ -5390,7 +5390,8 @@ PrivStatus ObjectPrivsMDTable::updateWhere(const 
std::string & setClause,
     //    <catalogName> "<schema_name>"."<object_name>", 
     //    object_type,
     //    object_owner, -- granteeID
    -//    (select auth_db_name from AUTHS where auth_id = object_owner), 
--granteeName
    +//    coalesce((select auth_db_name from AUTHS where auth_id = 
object_owner),
    +//             'DB__ROOT') --granteeName
    --- End diff --
    
    This is probably okay.  I am just wondering what happens if you initialize 
authorization, create tables with role and user owners other than DB__ROOT, 
then drop authorization.  Not sure if we reset object ownership.  Later when we 
initialize authorization, we may be missing things.   Some testing is needed 
and perhaps a new JIRA created.  Unfortunately I don't have a working version 
so I can't test.  I will test is out when I do and create a JIRA, if needed.


> Insert, delete and update operators should use specialized cost method 
> -----------------------------------------------------------------------
>
>                 Key: TRAFODION-25
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-25
>             Project: Apache Trafodion
>          Issue Type: Bug
>            Reporter: Qifan Chen
>            Assignee: David Wayne Birdsall
>              Labels: performance
>
> In Trafodion, insert, delete and update operators do not use a specialized 
> cost method that model the true operation involved. 
> As a result, these operators can be assigned a zero cost and the query plan 
> may not be optimal. In one example, a delete query against a partitioned 
> table may get a serial plan. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to