[
https://issues.apache.org/jira/browse/TRAFODION-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955166#comment-14955166
]
ASF GitHub Bot commented on TRAFODION-1521:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/118#discussion_r41885893
--- Diff: core/sql/nskgmake/Makerules.linux ---
@@ -80,20 +80,14 @@ OBJSUFFIX := o
#######################################################################
# Define several directories used by various parts of the Linux build
#######################################################################
-NSK_SQ := $(MY_SQROOT)
-NSK := $(MY_SQROOT)/sql/nsk
-XMPIROOT = $(NSK_SQ)/export/lib$(SQ_MBTYPE)
-NSKBIN = $(NSK_SQ)/export/bin$(SQ_MBTYPE)
-NSKROOT = $(NSK_SQ)/sql/nsk
+LIBROOT = $(MY_SQROOT)/export/lib$(SQ_MBTYPE)
+TRAF_BIN = $(MY_SQROOT)/export/bin$(SQ_MBTYPE)
+XMPIROOT = $(LIBROOT)
ifeq ($(SQ_BUILD_TYPE),release)
--- End diff --
Glad to see the NSK stuff cleaned up.
> Trafodion build should not require HBase to be installed
> --------------------------------------------------------
>
> Key: TRAFODION-1521
> URL: https://issues.apache.org/jira/browse/TRAFODION-1521
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-general
> Affects Versions: 1.1 (pre-incubation)
> Environment: Any
> Reporter: Hans Zeller
> Assignee: Hans Zeller
> Labels: build
> Fix For: 1.2-incubating
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> When we build Trafodion in a source tree, it should not be necessary to
> install HBase first.
> Until now, several build steps relied on an HBase installation:
> 1. Files in core/sql/executor include the libhdfs header file, hdfs.h. This
> file isn't available in the Trafodion source tree.
> 2. When we link certain executables like mxosrvr and sqlci, we specify
> -lhdfs, requiring the libhdfs.so DLL as well as the DLLs it depends on,
> libhadoop.so and libjvm.so.
> 3. Until recently, executor Java (core/sql/executor) files were compiled with
> javac invocations from a Makefile, requiring the HBase client jar files in
> the CLASSPATH. This got changed with TRAFODION-1502.
> 4. I missed some more Java files in the fix for TRAFODION-1502:
> core/sqf/src/seatrans/tm/hbasetmlib2. Those should also be moved to Maven.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
