[ 
https://issues.apache.org/jira/browse/TRAFODION-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15084084#comment-15084084
 ] 

ASF GitHub Bot commented on TRAFODION-1473:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/248#discussion_r48912365
  
    --- Diff: core/sql/executor/ExExeUtilLoad.cpp ---
    @@ -3098,19 +3119,25 @@ short ExExeUtilLobExtractTcb::work()
                break;
              }
     
    -       if (lobDataLen_ == 0)
    +       if (lobDataOutputLen == 0)
              {
                step_ = CLOSE_CURSOR_;
                break;
              }
     
    -       remainingBytes_ = (Lng32)lobDataLen_;
    +       remainingBytes_ = (Lng32)lobDataOutputLen;
            currPos_ = 0;
     
    -            if (lobTdb().getToType() == ComTdbExeUtilLobExtract::TO_FILE_)
    -              step_ = INSERT_FROM_STRING_;
    -            else
    -              step_ = RETURN_STRING_;
    +            /*if (lobTdb().getToType() == 
ComTdbExeUtilLobExtract::TO_FILE_)
    +              step_ = INSERT_FROM_STRING_;*/
    +            if (lobTdb().getToType() == 
ComTdbExeUtilLobExtract::TO_BUFFER_)
    +         {
    +           str_sprintf(statusString_," Success: LOB data length returned : 
%d", lobDataOutputLen);
    +          
    +           //lobTdb().setExtractSizeIOAddr((Int64)(&lobDataOutputLen));
    +           memcpy((char *)lobTdb().dataExtractSizeIOAddr(), (char 
*)&lobDataOutputLen,sizeof(Int64));
    +           step_ = RETURN_STATUS_;
    +         }
    --- End diff --
    
    Else we remain in the same step_? Could that cause an infinite loop?


> Adding external buffer and file input and extract support  for  LOB datatypes
> -----------------------------------------------------------------------------
>
>                 Key: TRAFODION-1473
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-1473
>             Project: Apache Trafodion
>          Issue Type: Task
>          Components: sql-cmp, sql-exe
>         Environment: Trafodion
>            Reporter: Sandhya Sundaresan
>            Assignee: Sandhya Sundaresan
>              Labels: features
>             Fix For: 1.2-incubating
>
>
> LOB datatype is disabled in Trafodion  until the following support is fully 
> in.
> Here are the list of tasks and items to support :
> 1. Support input of linux files (on platform)  into LOB columns.
> 2. Support extract of LOB data into linux files on platform.
> 3. Support input of hdfs files  into LOB columns.
> 4. Support extract of LOB data into hdfs files.
> 5. Support chunking to input a very large external file into LOB columns.
> 6. Use CQD concept to limit LOB max size and limit chunk size for extract 
> /input.
> TBD 
> 7. Support for  input/extract of external files off platform into LOB columns.
> 8. Support in connectivity and driver for real LOB data type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to