[ 
https://issues.apache.org/jira/browse/TRAFODION-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126569#comment-15126569
 ] 

ASF GitHub Bot commented on TRAFODION-1703:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/296#discussion_r51445704
  
    --- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/coprocessor/transactional/generated/TrxRegionProtos.java
 ---
    @@ -26558,6 +26558,16 @@ public Builder clearHasException() {
          * <code>required int64 auditSeqNum = 4;</code>
          */
         long getAuditSeqNum();
    +
    +    // required bool ageCommitted = 5;
    +    /**
    +     * <code>required bool ageCommitted = 5;</code>
    +     */
    +    boolean hasAgeCommitted();
    +    /**
    +     * <code>required bool ageCommitted = 5;</code>
    --- End diff --
    
    What is the point of the repeated <code>required bool ageCommitted = 
5;</code> comments? There seems to be several of them.


> Lower overhead in deleting old Tlog entries
> -------------------------------------------
>
>                 Key: TRAFODION-1703
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-1703
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: dtm
>    Affects Versions: 1.3-incubating
>            Reporter: Sean Broeder
>            Assignee: Sean Broeder
>             Fix For: 1.3-incubating
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Currently, Tlog entries are maintained for a period of time when there is a 
> chance they might be needed to help recover from some sort of failure.  After 
> that widow expires the old records can be deleted.
> The current mechanism starts a scanner on the region which sends every record 
> to the client Tlog component where the record is evaluated and if the 
> deletion criteria are met a Delete is created and sent back to the region.  
> This creates a lot of unnecessary message traffic since none of the contents 
> of the record is actually needed by the Tlog component during the maintenance 
> operation.
> It would be better to send the deletion criteria to the region so that the 
> region itself to perform the necessary housekeeping without sending all the 
> data back to the client Tlog component.
> I believe the endpoint coprocessor service could be used to perform this work.
> Comments?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to