[ 
https://issues.apache.org/jira/browse/TRAFODION-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330815#comment-15330815
 ] 

ASF GitHub Bot commented on TRAFODION-2060:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/545#discussion_r67072771
  
    --- Diff: core/sql/common/NumericType.h ---
    @@ -445,6 +443,99 @@ class SQLBPInt : public NumericType
     
     // ***********************************************************************
     //
    +//  SQLTiny : SQL TINY
    +//
    +// ***********************************************************************
    +class SQLTiny : public NumericType
    +{
    +public:
    +  // ---------------------------------------------------------------------
    +  // Constructor functions
    +  // ---------------------------------------------------------------------
    +  SQLTiny (NABoolean allowNegValues = TRUE, 
    +           NABoolean allowSQLnull = TRUE,
    +           CollHeap * heap =0);
    +  
    +   short getFSDatatype() const
    +    {
    +      if (isUnsigned())
    +   return REC_BIN8_UNSIGNED;
    +      else
    +   return REC_BIN8_SIGNED;
    +    }
    +
    +  NABoolean roundTripConversionToDouble() const { return TRUE; };
    +
    +  virtual Lng32 getMagnitude() const { return isUnsigned() ? 28 : 25; }
    --- End diff --
    
    What's "magnitude"?


> Add support for native tinyint datatype
> ---------------------------------------
>
>                 Key: TRAFODION-2060
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2060
>             Project: Apache Trafodion
>          Issue Type: Improvement
>            Reporter: Anoop Sharma
>            Assignee: Anoop Sharma
>            Priority: Minor
>
> Currently, tinyint datatype(1 byte integer) in trafodion is automatically 
> converted to smallint (2 byte integer) and treated like smallint.
> It causes values that are beyond the tinyint range to be inserted
> and selected.
> Same issue happens with hive tinyint datatypes which are also
> treated as smallint. That causes inconsistent behavior when that
> datatype is accessed or inserted from hive vs. trafodion.
> This jira is to add support for true tinyint datatype in table definitions,
> cast stmts, param typing and handling of hive tables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to