[
https://issues.apache.org/jira/browse/TRAFODION-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355617#comment-15355617
]
ASF GitHub Bot commented on TRAFODION-1988:
-------------------------------------------
Github user trinakrug commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/559#discussion_r69005466
--- Diff:
core/sqf/src/seatrans/tm/hbasetmlib2/src/main/java/org/trafodion/dtm/HBaseTxClient.java
---
@@ -420,14 +399,21 @@ public short abortTransaction(final long
transactionID) throws Exception {
if (useTlog) {
tLog.putSingleRecord(transactionID, -1, "ABORTED",
ts.getParticipatingRegions(), false);
}
- } catch(Exception e) {
- LOG.error("Returning from HBaseTxClient:abortTransaction, txid: "
+ transactionID + " tLog.putRecord: EXCEPTION");
+ } catch(IOException e) {
+ LOG.error("Returning from HBaseTxClient:abortTransaction, txid: "
+ transactionID + " tLog.putRecord: EXCEPTION", e);
return TransReturnCode.RET_EXCEPTION.getShort();
}
if ((stallWhere == 1) || (stallWhere == 3)) {
LOG.info("Stalling in phase 2 for abortTransaction");
- Thread.sleep(300000); // Initially set to run every 5 min
+ boolean loopBack = true;
+ do {
+ try {
+ Thread.sleep(300000); // Initially set to run every 5 min
+ } catch(InterruptedException ie) {
+ loopBack = true;
--- End diff --
Should there be a loopBack = false after Thread.sleep in the case where an
exception occurred but then the operation succeeded?
> Better java exception handling in the java layer of Trafodion
> -------------------------------------------------------------
>
> Key: TRAFODION-1988
> URL: https://issues.apache.org/jira/browse/TRAFODION-1988
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: dtm, sql-exe
> Affects Versions: 2.1-incubating
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
>
> Java exceptions are not handled in consistent manner in Trafodion. The SQL
> interface layer in Trafodion is capable of displaying the entire java stack
> trace to the client application when an exception is raised in java portion
> of the Trafodion/Hbase/Hdfs stack. However, there are portions of the code in
> Trafodion where the exceptions are not handled in a consistent manner. This
> JIRA attempts to fix this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
