[
https://issues.apache.org/jira/browse/TRAFODION-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415550#comment-15415550
]
ASF GitHub Bot commented on TRAFODION-2129:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/649#discussion_r74281350
--- Diff:
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/TransactionManager.java
---
@@ -2232,7 +2232,7 @@ public void doCommitDDL(final TransactionState
transactionState) throws Unsucces
if (retry)
retrySleep = retry(retrySleep);
}
- } while (retry == true);
+ } while (retry && retryCount++ <= RETRY_ATTEMPTS);
--- End diff --
The code you have is fine. It could be made a bit simpler though perhaps by
using just one variable, retryCount, and counting down instead of up. You could
then simply test retryCount > 0. In code paths where you decide to not retry,
just set retryCount = 0.
> Trafodion to avoid use of deprecated HBase APIs/Classes
> -------------------------------------------------------
>
> Key: TRAFODION-2129
> URL: https://issues.apache.org/jira/browse/TRAFODION-2129
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: dtm, sql-exe
> Affects Versions: 2.0-incubating
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Avoid the use of HConnection, HConnectionManager and, HBaseAdmin in Trafodion
> and use Connection, ConnectionFactory and Admin respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
