ASF GitHub Bot commented on TRAFODION-1988:

Github user DaveBirdsall commented on a diff in the pull request:

    --- Diff: core/sqf/src/seatrans/tm/hbasetmlib2/javaobjectinterfacetm.cpp ---
    @@ -421,21 +422,32 @@ bool  
JavaObjectInterfaceTM::getExceptionDetails(JNIEnv *jenv)
            _tlp_error_msg = error_msg;
            return false;
    +   error_msg = new std::string("");
    +   appendExceptionMessages(jenv, a_exception, error_msg);
    +   *error_msg += "\n";
    +   _tlp_error_msg = error_msg;
    +   return true;
    +void JavaObjectInterfaceTM::appendExceptionMessages(JNIEnv *jenv, 
jthrowable a_exception, std::string *error_msg)
    --- End diff --
    If we don't expect error_msg to be null, it might be better to code this as 
a reference parameter rather than a pointer.

> Better java exception handling in the java layer of Trafodion
> -------------------------------------------------------------
>                 Key: TRAFODION-1988
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-1988
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: dtm, sql-exe
>    Affects Versions: 2.1-incubating
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Selvaganesan Govindarajan
> Java exceptions are not handled in consistent manner in Trafodion. The SQL 
> interface layer in Trafodion is capable of displaying the entire java stack 
> trace to the client application when an exception is raised in java portion 
> of the Trafodion/Hbase/Hdfs stack. However, there are portions of the code in 
> Trafodion where the exceptions are not handled in a consistent manner. This 
> JIRA attempts to fix this.

This message was sent by Atlassian JIRA

Reply via email to