[
https://issues.apache.org/jira/browse/TRAFODION-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583340#comment-15583340
]
ASF GitHub Bot commented on TRAFODION-1893:
-------------------------------------------
Github user hegdean commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/763#discussion_r83725920
--- Diff: win-odbc64/Install/win64_installer/installer.iss ---
@@ -152,6 +141,40 @@ begin
Result := (GetUninstallString() <> '');
end;
+procedure CurStepChanged(CurStep: TSetupStep);
+var
+ bRedistNeedsInstall: Boolean;
+ sDefaultBrowserName: String;
+ sDefaultBrowserReg: String;
+ sDefaultBrowserValue: String;
+ iQuotePos: Integer;
+ lLength: Longint;
+ iRetCode: Integer;
+begin
+ if CurStep=ssPostInstall then
+ begin
+ bRedistNeedsInstall := VCRedistNeedsInstall();
+ if bRedistNeedsInstall=True then
+ begin
+ MsgBox('Install of Visual C++ Redistributable Packages for Visual
Studio 2013 is not dectected.'+ #13#10#13#10 + 'Please download
vcredist_x64.exe from Microsoft Download Centre and install it.',
mbInformation, MB_OK);
--- End diff --
Can we change the message to be as follows:
Run-time dependency needed by the driver is not found. Proceeding to
download and install run-time dependency from Microsoft.
> Remove vcredist from win-odbc build
> -----------------------------------
>
> Key: TRAFODION-1893
> URL: https://issues.apache.org/jira/browse/TRAFODION-1893
> Project: Apache Trafodion
> Issue Type: Bug
> Components: client-odbc-windows
> Affects Versions: 2.0-incubating
> Reporter: Steve Varnau
>
> per TRAFODION-1836, the licensing of MS program is not such that we can
> bundle vcredist with binary distribution of Trafodion.
> So we need to not bundle vcredist at build time. Instead, we should just
> provide check that the libraries are installed or prompt user to download
> them with URL.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
