[
https://issues.apache.org/jira/browse/TRAFODION-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590037#comment-15590037
]
ASF GitHub Bot commented on TRAFODION-2296:
-------------------------------------------
Github user prashanth-vasudev commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/768#discussion_r84178660
--- Diff:
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/TransactionManager.java
---
@@ -1300,11 +1380,14 @@ public Integer doPrepareX(final
List<TransactionRegionLocation> locations, final
commitErr = TransactionalReturn.COMMIT_UNSUCCESSFUL;
canCommit = false;
readOnly = false;
+ LOG.warn(errMsg);
transactionState.addRegionToIgnore(locations.get(resultCount)); // No need to
re-abort.
break;
default:
- LOG.warn("Received invalid return code from requestCommit " +
commitStatus + " for transaction " + transactionId + " throwing
CommitUnsuccessfulException");
- throw new CommitUnsuccessfulException("Unexpected return code
from prepareCommit: " + commitStatus);
+ CommitUnsuccessfulException cue = new
CommitUnsuccessfulException(errMsg);
+ if (LOG.isWarnEnabled())
--- End diff --
This can be logged as error unconditionally since it is pretty significant.
> Change the errors/warnings messages to be consistent in the transaction
> manager subsystem
> -----------------------------------------------------------------------------------------
>
> Key: TRAFODION-2296
> URL: https://issues.apache.org/jira/browse/TRAFODION-2296
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: dtm
> Affects Versions: 2.1-incubating
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
>
> Error and Warning messages need to provide sufficient information for the
> failure during commit and rollback transaction
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
