[
https://issues.apache.org/jira/browse/TRAFODION-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610257#comment-15610257
]
ASF GitHub Bot commented on TRAFODION-2127:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/772#discussion_r85251226
--- Diff: core/sql/generator/GenPreCode.cpp ---
@@ -10715,7 +10808,10 @@ RelExpr * PhysicalFastExtract::preCodeGen
(Generator * generator,
if (nodeIsPreCodeGenned())
return this;
- generator->setIsFastExtract(TRUE);
+ if (getIsMainQueryOperator())
+ generator->setIsFastExtract(TRUE);
+ else
+ generator->setContainsFastExtract(TRUE);
--- End diff --
The "is" and the "contains" refer to the entire statement. The
Generator::isFastExtract() method is used to determine the overall statement
type. What I needed was a flag indicating that there is some fast extract
somewhere in the statement (e.g. the one used to populate a temp table), while
the overall statement type is something else, like a select. I added a comment
to make that more clear.
> enhance Trafodion implementation of WITH clause
> -----------------------------------------------
>
> Key: TRAFODION-2127
> URL: https://issues.apache.org/jira/browse/TRAFODION-2127
> Project: Apache Trafodion
> Issue Type: Improvement
> Reporter: liu ming
> Assignee: Hans Zeller
>
> TRAFODION-1673 described some details about how to support WITH clause in
> Trafodion.
> As initial implementation, we use a simple pure-parser method.
> That way, Trafodion can support WITH clause functionally, but not good from
> performance point of view,
> also need to enhance the parser to be more strict in syntax.
> This JIRA is a follow up JIRA, to track following effort to support Trafodion
> WITH clause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
