[ 
https://issues.apache.org/jira/browse/TRAFODION-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613714#comment-15613714
 ] 

ASF GitHub Bot commented on TRAFODION-2317:
-------------------------------------------

Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/794#discussion_r85448965
  
    --- Diff: core/sql/executor/ExHdfsScan.cpp ---
    @@ -1700,6 +1714,138 @@ char * 
ExHdfsScanTcb::extractAndTransformAsciiSourceToSqlRow(int &err,
       return NULL;
     }
     
    +void ExHdfsScanTcb::computeRangesAtRuntime()
    --- End diff --
    
    I suppose this computation is being repeated by each esp. Is there a way by 
which it can done once and shared (say computed during fixup)? If possible, 
this would be a minor enhancement for later. I do see some comment indicating 
that only portions relevant to this esp are computed. Maybe some comment 
including a statement on which locality_balance_level this corresponds to will 
help.


> Implement relational operator for common subexpressions and transformation
> --------------------------------------------------------------------------
>
>                 Key: TRAFODION-2317
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2317
>             Project: Apache Trafodion
>          Issue Type: Sub-task
>          Components: sql-cmp
>    Affects Versions: 2.1-incubating
>            Reporter: Hans Zeller
>            Assignee: Hans Zeller
>
> This subtask provides the infrastructure for handling common subexpressions:
> - A relational CommonSubExprRef operator to track the locations of common 
> subexpressions in the query tree.
> - Methods to analyze the common subexpressions in the tree and to determine 
> whether a transformation is possible and what the temporary table would look 
> like.
> - Methods to do the actual query tree transformation.
> - Some needed changes in bookkeeping and runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to