[
https://issues.apache.org/jira/browse/TRAFODION-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631146#comment-15631146
]
ASF GitHub Bot commented on TRAFODION-2293:
-------------------------------------------
Github user traflm commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/810#discussion_r86275214
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -1554,7 +1554,7 @@ echo "$MY_LOCAL_SW_DIST/${HBASE_TAR}"
org.apache.hadoop.hbase.security.visibility.VisibilityController"
fi
- if [[ "$HBASE_DISTRO" != "APACHE1.2" || "$HBASE_DISTRO" != "CDH5.7"]];
then
+ if [[ "$HBASE_DISTRO" != "APACHE1.2" && "$HBASE_DISTRO" != "CDH5.7"]];
then
--- End diff --
not able to determine if this work correctly or not, @mashengchen , please
describe the UT you did after this change.
Since this only change '||' to '&&', but from what others reported, there
are other issues like 'space' and the local_hadoop directory. So it is a must
to run it yourself before I can approve this.
So please describe how you did the UT.
> apache hbase trx jar file name should not contain the minor version number.
> ---------------------------------------------------------------------------
>
> Key: TRAFODION-2293
> URL: https://issues.apache.org/jira/browse/TRAFODION-2293
> Project: Apache Trafodion
> Issue Type: Improvement
> Reporter: Eason Zhang
> Assignee: mashengchen
>
> Currently the apache version of trx jar file name format is
> hbase-trx-apache1_x_x-2.0.0.jar, trafodion is only care about the major
> version of hbase, for example, 1.0, 1.1, so it should be better to set hbase
> trx format like this: hbase-trx-apache1_x-2.0.0.jar
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
