[
https://issues.apache.org/jira/browse/TRAFODION-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634203#comment-15634203
]
ASF GitHub Bot commented on TRAFODION-2322:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/811#discussion_r86439364
--- Diff: core/sql/ustat/hs_cli.cpp ---
@@ -5442,12 +5427,17 @@ NAString
HSSample::getTempTablePartitionInfo(NABoolean unpartitionedSample,
//
void HSSample::addTruncatedSelectList(NAString & qry)
{
+ bool first = true;
for (Lng32 i = 0; i < objDef->getNumCols(); i++)
{
- if (i)
- qry += ", ";
+ if (!ComTrafReservedColName(*objDef->getColInfo(i).colname))
--- End diff --
Yes, probably not worth the trouble, if it's difficult to implement. Sorry,
I did not look at the details of the context where this method is used. Does it
have separate logic to handle syskey, salt and divisioning columns - if
necessary. I think just adding a comment in a future checkin would be enough
for now.
> UPDATE STATS for Hive TPC-H Lineitem table takes much longer now
> ----------------------------------------------------------------
>
> Key: TRAFODION-2322
> URL: https://issues.apache.org/jira/browse/TRAFODION-2322
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-cmp
> Affects Versions: 2.0-incubating
> Environment: All
> Reporter: David Wayne Birdsall
> Assignee: David Wayne Birdsall
>
> When using a LINEITEM table with about 12 million rows, and storing that
> LINEITEM table in Hive files, UPDATE STATISTICS has regressed in its
> performance. On one test system, the elapsed time changed from 6 minutes 20
> seconds to 31 minutes 31 seconds.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
