[
https://issues.apache.org/jira/browse/TRAFODION-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652436#comment-15652436
]
ASF GitHub Bot commented on TRAFODION-2256:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/827#discussion_r87304086
--- Diff: install/installer/traf_start ---
@@ -58,19 +58,19 @@ else
error1392=$(grep "1392" $SQ_ROOT/initializeErrors.txt | wc -l)
error1395=$(grep "1395" $SQ_ROOT/initializeErrors.txt | wc -l)
if [ "$error1395" -ge "1" ] || [ "$error1392" -ge "1" ]; then
- ssh $STARTING_NODE "cd $SQ_ROOT/sql/scripts; echo \"get version
of metadata;\" | sqlci" | tee -a $SQ_ROOT/initalizeErrors.txt
+ ssh $STARTING_NODE "cd $SQ_ROOT/sql/scripts; echo \"get version
of metadata;\" | sqlci" | tee -a $SQ_ROOT/initializeErrors.txt
metadataCurrent=$(grep "Metadata is current"
$SQ_ROOT/initializeErrors.txt | wc -l)
if [[ "$metadataCurrent" -ne "1" ]]; then
ssh $STARTING_NODE "cd $SQ_ROOT/sql/scripts; echo
\"initialize Trafodion, upgrade;\" | sqlci" | tee -a
$SQ_ROOT/initializeErrors.txt
fi
- fi
-
- if [ "$?" != "0" ]; then
- echo "***ERROR: initialize Trafodion failed. Check install log
files for details." | tee -a $INSTALL_LOG
- exit -1;
- fi
+ else
--- End diff --
What if the initialize trafodion, upgrade fails, shouldn't we check that
for errors as well? This else would prevent that as far as I can see. Maybe
better to remove the "-a" from the tee command on line 64 and overwrite file
initializeErrors.txt. Then remove this else statement on line 66 and continue
unconditionally?
> traf_start init traf not looking true errors
> ---------------------------------------------
>
> Key: TRAFODION-2256
> URL: https://issues.apache.org/jira/browse/TRAFODION-2256
> Project: Apache Trafodion
> Issue Type: Bug
> Components: installer
> Reporter: Amanda Moran
> Assignee: Steve Varnau
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
