[
https://issues.apache.org/jira/browse/TRAFODION-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685251#comment-15685251
]
ASF GitHub Bot commented on TRAFODION-2231:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/725#discussion_r89021375
--- Diff: core/sqf/src/seatrans/tm/hbasetmlib2/hbasetm.cpp ---
@@ -860,7 +862,10 @@ int CHbaseTM::createTable(int64 pv_transid,
jba_tbldesc,
j_keys);
if (getExceptionDetails(NULL)) {
- tm_log_write(DTM_TM_JNI_ERROR, SQ_LOG_ERR, (char
*)"CHbaseTM::createTable()", (char *)_tlp_error_msg->c_str(), pv_transid);
+ errstrlen = ((int)_tlp_error_msg->length() < errstrlen) ?
(int)_tlp_error_msg->length() : errstrlen;
+ strncpy(errstr, _tlp_error_msg->c_str(), errstrlen);
+ errstr[errstrlen -1] = '\0';
--- End diff --
Is it possible at line 865 that errstrlen could be assigned zero? (For
example, could (int)_tlp_error_msg->length() return zero?) If so, then this
line will clobber the byte just before the beginning of errstr. A reversed
buffer overrun.
> DDL create/drop detailed error string is not propagated
> -------------------------------------------------------
>
> Key: TRAFODION-2231
> URL: https://issues.apache.org/jira/browse/TRAFODION-2231
> Project: Apache Trafodion
> Issue Type: Bug
> Components: dtm
> Reporter: Prashanth Vasudev
> Assignee: Prashanth Vasudev
> Fix For: 2.1-incubating
>
>
> TRAFODION-2148 takes care of reporting error code in failure scenario,
> however the cause/error string or stack trace is missing for additional info.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
