[ 
https://issues.apache.org/jira/browse/TRAFODION-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688064#comment-15688064
 ] 

ASF GitHub Bot commented on TRAFODION-2353:
-------------------------------------------

Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/842#discussion_r89219091
  
    --- Diff: core/sql/optimizer/ItemExpr.cpp ---
    @@ -7922,10 +7924,46 @@ ItemExpr * InverseOrder::removeInverseOrder()
     }
     
     // -----------------------------------------------------------------------
    +// member functions for PatternMatchingFunction.
    +// -----------------------------------------------------------------------
    +PatternMatchingFunction::~PatternMatchingFunction() {}
    +
    +// -----------------------------------------------------------------------
     // member functions for Like
     // -----------------------------------------------------------------------
     Like::~Like() {}
     
    +Regexp::~Regexp() {}
    +
    +
    +ItemExpr * Regexp::copyTopNode(ItemExpr *derivedNode, CollHeap* outHeap)
    +{
    +  ItemExpr *result = NULL;
    +
    +  if (derivedNode == NULL)
    +    {
    +      switch (getArity())
    +   {
    +   case 2:
    +     result = new (outHeap) Regexp(child(0), child(1),
    --- End diff --
    
    The copyTopNode() method is not supposed to copy any children. I think the 
children should be initialized with NULL here.


> support of the regexp operator
> ------------------------------
>
>                 Key: TRAFODION-2353
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2353
>             Project: Apache Trafodion
>          Issue Type: New Feature
>            Reporter: liu ming
>            Assignee: liu ming
>
> It is desired to have REGEXP.
> Some initial researching already done in: 
> https://cwiki.apache.org/confluence/display/TRAFODION/Example+Enhancement%3A+Add+a+New+Built-in+Function
> This JIRA is to add REGEXP operator, not including functions may required 
> future, if required, related JIRA will be created.
> The good advice in the wiki is to do new features incrementally. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to